Re: [PATCH 2/2] make fbcon unregister when unloaded

From: Randy Dunlap
Date: Tue May 22 2007 - 18:00:56 EST


On Tue, 22 May 2007 14:44:52 -0700 Jesse Barnes wrote:

> When unloaded, the fbcon driver should unregister itself from the VT
> subsystem using unbind_con_driver. This patch makes it use the newly
> exported function to do just that.
>
> Signed-off-by: Jesse Barnes <jesse.barnes@xxxxxxxxx>
>
> diff -Napur -X /home/jbarnes/dontdiff --exclude=Makefile linux-2.6.22-rc2/drivers/video/console/fbcon.c linux-2.6.22-rc2-modesetting/drivers/video/console/fbcon.c
> --- linux-2.6.22-rc2/drivers/video/console/fbcon.c 2007-05-18 21:06:17.000000000 -0700
> +++ linux-2.6.22-rc2-modesetting/drivers/video/console/fbcon.c 2007-05-22 14:26:20.000000000 -0700
> @@ -2937,6 +2937,21 @@ static int fbcon_mode_deleted(struct fb_
> return found;
> }
>
> +static int fbcon_fb_unbind(int idx)
> +{
> + int i;
> +
> + for (i = 0; i < MAX_NR_CONSOLES; i++) {
> + /* Assure we do not unbind other drivers */
> + if (idx == con2fb_map[i])
> + /* can be optimize to minimize multiple calls to
> + unbind_con_driver() */

/*
* can be optimized to minimize multiple calls
* to unbind_con_driver()
*/

> + unbind_con_driver(&fb_con, i, i, 0);
> + }
> +
> + return 0;
> +}

Lots of whitespace mangling there (mostly spaces instead of tabs).

> +
> static int fbcon_fb_unregistered(int idx)
> {
> int i;

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/