Re: v2.6.21-rt3

[Daniel Walker]

On Tue, 2007-05-22 at 10:25 +0200, Ingo Molnar wrote:
> * Daniel Walker <dwalker@xxxxxxxxxx> wrote:
> 
> > I copied the patch into the first email, I did look at it which is why 
> > you got an email. Your introducing the patch , it's for you to explain 
> > why it needs to be there.. considering that the comment says "hack" in 
> > it, I have to wonder what the non-hack version is ..
> 
> you might not have realized it, but the problem i think was the attitude 
> you showed in the very first sentence:

I was not intending any attitude. I had no idea where those changes came
from ..

> > Where did the arm ep93xx changes come from? It looks like patch below 
> > came in with them in 2.6.21-rt6 ..
> 
> AFAICS Thomas just mirrored that snotty comment back to you, and yes, 
> when you are on the receiving end it feels nasty, doesnt it? So please 
> restart and rephrase that into a more polite form and you might get an 
> answer (although i certainly do not talk for Thomas). Something like:

I don't read the sentence you quoted as snotty at all ..  I had no idea
where the changes came from, and I was simply asking that.. Since there
isn't a history for the -rt patch, I honestly don't know where some of
the code comes from ..

Since I had no idea that Thomas wrote that code, there's no premeditated
aggravation, or flame bait there.. 

> > Thomas, could you give me a bit more information about why the arm 
> > ep93xx changes were done in 2.6.21-rt6? I do not seem to understand 
> > the reason behind that change. I've attached the change below. Thanks!
> 
> You are asking Thomas a favor after all... Be a bit more polite when 
> asking others, and a completely new world might open up for you :-)

I don't see that as me asking a favor.. If a patch crosses LKML and I
ask "Why does this hunk exist?" that's not a favor. That is pure code
review, which is exactly what I was doing in this thread. Which is
reviewing code and asking questions..

I hope you don't read my comments above as snotty cause it's not suppose
to be, just conversation..

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/