Re: [PATCH]serial: make early_uart to use early_param instead of console_initcall

[Bjorn Helgaas]

On Monday 21 May 2007 02:36:16 pm Yinghai Lu wrote:
> On 5/21/07, Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote:
> > > with console=uart, you need to call early_serial_console_init
> > > explictly in your arch setup_arch to get early console.
> >
> > Can't we just do:
> >
> >   early_param("console", setup_early_console);
> 
> please check following patch. it will take
> console=early8250,io,0x3f8,9600n8

How about just plain "console=8250,io,..."?

> You may need to remove early_serial_console_init in your ia64
> setup_arch, and some dummy function for set_fixmap_nocache, and
> __fix_to_virt in your asm-ia64/fixmap.h

I don't want to add asm-ia64/fixmap.h with dummy definitions
just for this.

Can we add this:

  asm-ia64/io.h:   #define bt_ioremap ioremap
  asm-x86_64/io.h: #define bt_ioremap early_ioremap

and use bt_ioremap instead?

> new command line will be
> 
>       earlycon=early8250,io,0x3f8,9600n8
>       earlycon=early8250,mmio,0xff5e0000,115200n8
>  or
>       console=early8250,io,0x3f8,9600n8
>       console=early8250,mmio,0xff5e0000,115200n8

If you can make "console=early8250" work, we don't need
"earlycon=early8250", do we?

Your patch adds trailing whitespace and a few cases of"<space><tab>".
I use this in my .vimrc to catch these:

  highlight WhitespaceEOL ctermbg=red guibg=red
  match WhitespaceEOL /\s\+$\| \+\ze\t/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/