Re: [PATCH] sata_promise: Port enumeration order - SATA 150 TX4,

[Hans A Eide]

> Evan Harris wrote:
>>
>> I have a card that mirrors this one from your list:
>>
>> Retail name: SATA300 TX4
>> Chip label: PDC40718-GP  SATAII300
>> Vendor-Device number: 105a:3d17 (rev 02)
>>
>> Through testing, I've found linux 2.6.16 and 2.6.17 find the  
ports in
>> this order (the list is ordered by linux detection):
>>
>> 1. silkscreen port 3
>> 2. silkscreen port 2
>> 3. silkscreen port 4
>> 4. silkscreen port 1
>>> NOTE: the patch I have submitted (
>>> http://marc.theaimsgroup.com/?l=linux- 
ide&m=114082978311290&w=2 ) is a
>>> solution that doesn't know about the older Promise SATA  
controllers,
>>> which are not affected with the "new wiring" problem, so the older
>>> controllers will appear screwed if you use it.
>>>
>>> Hopefully we will collect enough info about all the SATA Promise
>>> controllers to distinguish the new and the old wiring controllers,
>>> then produce a new patch that will be a correct solution to the  
"new
>>> wiring" problem.
>
> Mikael Pettersson has been doing some excellent work recently on
> sata_promise.  If enough data has been collected on this sata_promise
> port enumeration problem, maybe the data could be collated and  
proposed
> via Mikael as a patch?
>
> 	Jeff

Sorry, any updates on this?

An updated patch for "new wiring" would be

--- sata_promise.c      2007-05-20 21:35:54.000000000 +0200
+++ sata_promise.c.new_enum     2007-05-21 21:52:38.000000000 +0200
@@ -915,9 +915,11 @@
                hp->flags |= PDC_FLAG_GEN_II;
                /* Fall through */
        case board_20319:
-                       probe_ent->n_ports = 4;
-               pdc_ata_setup_port(&probe_ent->port[2], base + 0x300,  
base + 0x600);
-               pdc_ata_setup_port(&probe_ent->port[3], base + 0x380,  
base + 0x700);
+               probe_ent->n_ports = 4;
+               pdc_ata_setup_port(&probe_ent->port[0], base + 0x380,  
base + 0x400);
+               pdc_ata_setup_port(&probe_ent->port[1], base + 0x280,  
base + 0x500);
+               pdc_ata_setup_port(&probe_ent->port[2], base + 0x200,  
base + 0x600);
+               pdc_ata_setup_port(&probe_ent->port[3], base + 0x300,  
base + 0x700);
                break;
        case board_2057x:
                hp->flags |= PDC_FLAG_GEN_II;


Correct?


Hans


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/