Re: [PATCH]serial: make early_uart to use early_prarm instead of console_initcall

[Bjorn Helgaas]

On Monday 21 May 2007 11:36:58 am Yinghai Lu wrote:
> On 5/21/07, Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote:
> > > earlycon=uart,io,0x3f8,9600n8
> > > earlycon=uart,io,0x3f8,9600n8 console=tty0
> > > earlycon=uart,mmio,0xff5e0000,115200n8
> >
> > Why do we have to have a new "earlycon" argument?  Why can't we just
> > parse "console=uart" early?
> 
> with console=uart, you need to call early_serial_console_init
> explictly in your arch setup_arch to get early console.

Can't we just do:

  early_param("console", setup_early_console);

and have setup_early_console() ignore everything except "uart"?
 
> with console_initcall(early_uart_console_init), the early_uart_console
> will be called via console_init in start_kernel, init/main.c that is
> not real early console.

I agree that's too late.

Bjorn

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/