Re: [PATCH] lockdep: lock contention tracking

From: Ingo Molnar
Date: Mon May 21 2007 - 06:58:24 EST



* Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Mon, May 21, 2007 at 11:36:39AM +0200, Ingo Molnar wrote:
> > you got the history wrong i think: the first version of lockdep was
> > released to lkml a year ago (May 2006), while the first time you
> > mentioned your lock contention patch was November 2006 and you released
> > it to lkml in December 2006 - so it was _you_ who was "replicating the
> > same work", not lockdep :-) And this was pointed out to you very early
> > on, many months ago.
>
> And lockmeter, the very first patch of this sort is from the 90s, but
> got mostly ignored here on lkml, of course :)

i certainly did not ignore lockmeter - i periodically tried it and even
considered adding it to -rt. But it was always pretty problematic from
an impact POV:

23 files changed, 2659 insertions(+), 13 deletions(-)

and nobody pushed strong enough to get it included. But ... Peter's
patch could perhaps be extended to cover similar stats as lockmeter,
ontop of the existing lockdep instrumentation. Peter, can you see any
particular roadblocks with that?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/