Re: signals logged / [RFC] log out-of-virtual-memory events

From: Andrea Righi
Date: Mon May 21 2007 - 06:45:22 EST


Andi Kleen wrote:
>> + switch(sig) {
>> + case SIGQUIT:
>> + case SIGILL:
>> + case SIGTRAP:
>> + case SIGABRT:
>> + case SIGBUS:
>> + case SIGFPE:
>> + case SIGSEGV:
>> + case SIGXCPU:
>> + case SIGXFSZ:
>> + case SIGSYS:
>> + case SIGSTKFLT:
>
> Unconditional? That's definitely a very bad idea. If anything only unhandled
> signals should be printed this way because some programs use them internally.
> But I think your list is far too long anyways.
>
> -Andi
>

Maybe you could use somthing similar to unhandled_signal() in
arch/x86_64/mm/fault.c, but I agree that the list seems a bit too long...

-Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/