Re: [PATCH] signalfd: retrieve multiple signals with one read() call

From: Davide Libenzi
Date: Sun May 20 2007 - 15:17:58 EST


On Sat, 19 May 2007, Davi Arnaut wrote:

> Hi,
>
> Gathering signals in bulk enables server applications to drain a signal
> queue (almost full of realtime signals) more efficiently by reducing the
> syscall and file look-up overhead.
>
> Very similar to the sigtimedwait4() call described by Niels Provos,
> Chuck Lever, and Stephen Tweedie in a paper entitled "Analyzing the
> Overload Behavior of a Simple Web Server". The paper lists more details
> and advantages.

That paper is a pre-epoll thing. Nowadays I see no value in using RT
signals as main event gathering mechanism ;)


> Signed-off-by: Davi E. M. Arnaut <davi@xxxxxxxxxxxxx>

The patch looks otherwise good to me, and I see no reasons why we
shoulnd't be fetching more than one signal if available.

Acked-by: Davide Libenzi <davidel@xxxxxxxxxxxxxxx>



- Davide


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/