Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code
From: Arnd Bergmann
Date: Sun May 20 2007 - 11:39:21 EST
On Sunday 20 May 2007, Stefan Richter wrote:
> maybe we should change
>
> /* argument to RAW1394_IOC_GET_CYCLE_TIMER ioctl */
> struct raw1394_cycle_timer {
> /* contents of Isochronous Cycle Timer register,
> as in OHCI 1.1 clause 5.13 (also with non-OHCI hosts) */
> __u32 cycle_timer;
>
> /* local time in microseconds since Epoch,
> simultaneously read with cycle timer */
> __u64 local_time;
> };
>
> to
>
> /* argument to RAW1394_IOC_GET_CYCLE_TIMER ioctl */
> struct raw1394_cycle_timer {
> /*
> * least significant 32 bits are contents of Isochronous Cycle
> * Timer register, as in OHCI 1.1 clause 5.13 (also with
> * non-OHCI hosts)
> */
> __u64 cycle_timer;
>
> /*
> * local time in microseconds since Epoch,
> * simultaneously read with cycle timer
> */
> __u64 local_time;
> };
>
> before a libraw1394 with get-cycle-timer support is released.
Yes, if you still have the chance to change this without breaking
users, that would be ideal.
I assume that struct raw1394_iso_packets is already set in stone,
right? Otherwise it would be good to make that a compatible structure
as well.
Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/