Re: [PATCH] Extract common MODULE_INFO content into newmoduleinfo.h.

From: David Rientjes
Date: Sun May 20 2007 - 04:48:41 EST


On Sun, 20 May 2007, Robert P. J. Day wrote:

> diff --git a/include/linux/moduleinfo.h b/include/linux/moduleinfo.h
> new file mode 100644
> index 0000000..cee86a9
> --- /dev/null
> +++ b/include/linux/moduleinfo.h
> @@ -0,0 +1,18 @@
> +#ifndef _LINUX_MODULEINFO_H
> +#define _LINUX_MODULEINFO_H
> +
> +#ifdef MODULE
> +#include <linux/stringify.h>
> +#define ___module_cat(a,b) __mod_ ## a ## b
> +#define __module_cat(a,b) ___module_cat(a,b)
> +#define __MODULE_INFO(tag, name, info) \
> +static const char __module_cat(name,__LINE__)[] \
> + __attribute_used__ \
> + __attribute__((section(".modinfo"),unused)) = __stringify(tag) "=" info

This isn't a function definition so __attribute_used__ (which is
deprecated anyway) doesn't mean anything. Please simply use
__maybe_unused and remove "unused" from the second attribute.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/