Re: [PATCH (v2)] crypto: Remove pointless padlock module

[Simon Arlott]

On 18/05/07 07:45, Herbert Xu wrote:
> On Sun, Apr 29, 2007 at 09:01:10AM +0100, Simon Arlott wrote:
> > When this is compiled in it is run too early to do anything useful:
> > [    6.052000] padlock: No VIA PadLock drivers have been loaded.
> > [    6.052000] padlock: Using VIA PadLock ACE for AES algorithm.
> > [    6.052000] padlock: Using VIA PadLock ACE for SHA1/SHA256 algorithms.
> >
> > When it's a module it isn't doing anything special, the same functionality 
> > can be provided in userspace by "probeall padlock padlock-aes padlock-sha" 
> > in modules.conf if it is required.
>
> BTW, I noticed that this prevented CRYPTO_ALGAPI from being marked as m
> since it was selected by CRYPTO_DEV_PADLOCK.  So I'm turning it into a
> tristate again.

It should be a bool that doesn't select anything, the AES and SHA modules 
will select CRYPTO_ALGAPI. It could also depend on MVIAC3_2 || MVIA_C7 
instead of X86_32.

--
Simon Arlott
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/