Re: [PATCH] LogFS take three

[Jan Engelhardt]

On May 19 2007 02:15, Rob Landley wrote:
>> > +
>> > +static inline struct logfs_inode *LOGFS_INODE(struct inode *inode)
>> > +{
>> > +	return container_of(inode, struct logfs_inode, vfs_inode);
>> > +}
>> 
>> Do these need to be uppercase?
>
>I'm trying to keep it clear in my head...
>
>When do you need to say __always_inline and when can you get away with 
>just saying "static inline"?

When using "static inline", the compiler may ignore the inline keyword 
(it's just a hint), and leave the function as a standalone function.

When CONFIG_FORCED_INLINING is active, and it is by default, inline is 
always substituted by __always_inline, to be on the safe side. Some code 
needs to be always inline; but not all code has been checked whether it 
is safe to go from __always_inline to inline.


	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/