Re: [git patches] net driver updates

From: Andrew Morton
Date: Fri May 18 2007 - 17:57:10 EST


On Fri, 18 May 2007 23:46:21 +0200
Mariusz Koz__owski <m.kozlowski@xxxxxxxxxx> wrote:

> Hello,
>
> > diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h
> > index 7053026..111f23d 100644
> > --- a/drivers/net/smc91x.h
> > +++ b/drivers/net/smc91x.h
> > @@ -279,6 +279,40 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg)
>
> ...
>
> > +#define SMC_outb(v, a, r) __ __ __outw(((inw((a)+((r)&~1))*(0xff<<8*(r%2)))) | ((v)<<(8*(r&2)))), (a) + ((r)&~1))
>
> This one has unbalanced parenthesis.
>

I dunno how you can tell - I can't count that high.

Can this be programmed in C, rather than in cpp?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/