Re: [PATCH] ubi: kill homegrown endian macros

From: Al Viro
Date: Fri May 18 2007 - 04:39:27 EST


On Fri, May 18, 2007 at 09:58:25AM +0300, Artem Bityutskiy wrote:
> Al Viro wrote:
> >BTW, you can simply typedef __be16 ubi16_t; etc. and define conversion
> >functions as cpu_to_ubi16(x) being (__force ubi16_t)cpu_to_be16(x), etc.
> >
> >sparse will do all checks just fine, you still have bitwise operations
> >(might or might be not relevant in your case) and for gcc it simply
> >becomes __be16, etc - i.e. an integer type.
>
> Err, what is the benefit of it? If we relied on sparce, why not would we be
> just using __be16 directly?

Because you might legitimately want your type to be *not* mixed with whatever
other big-endian 16bit types you have out there?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/