Re: [PATCH] ubi: kill homegrown endian macros

From: David Miller
Date: Thu May 17 2007 - 16:56:32 EST


From: Artem Bityutskiy <dedekind@xxxxxxxxxxxxx>
Date: Thu, 17 May 2007 17:50:43 +0300

> Well, I see the good side of your change - no home-brewed media<->cpu
> things. Fair enough and nice. But why don't you make __be32 a struct
> (just like I do) so that compiler could complain then?

structs get passed on the stack instead of via registers, regardless
of size, when passed as arguments on some architectures, so there is a
terrible performance cost of doing things that way
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/