Re: [PATCH] uselib: add missing MNT_NOEXEC check

[Ulrich Drepper]

On 5/17/07, Christoph Hellwig <hch@xxxxxx> wrote:
> We don't allow loading ELF shared library from noexec points so the
> same should apply to sys_uselib aswell.

Correct.  But...

>         error = -EINVAL;
> +       if (nd.mnt->mnt_flags & MNT_NOEXEC)
> +               goto exit;

... the error here should be EACCES.  Aside from that you get an ACK from me.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/