Re: [PATCH] INPUT: Sanitize PIT locking in pcspkr

[Thomas Gleixner]

Dmitry,

On Thu, 2007-05-17 at 10:15 -0400, Dmitry Torokhov wrote:
> Hi Thomas,
> 
> > +#include <asm/i8253.h>
> 
> I don't see this file in include/asm-i386 and your patch only creates
> asm-x86_64...

[tglx@inhell4 linux-2.6.21]$ ls include/asm-i386/i82*
include/asm-i386/i8253.h  include/asm-i386/i8259.h

> BTW, is there any reason 8253pit.h can't be used...?

The i386 lock is already exported in i8253.h

> Hmm... The best way IMO woudl be if arch code attached spinlock that
> should be used by pcspkr driver to pcspkr platform device (as
> platform_data) and we would not have private lock at all.

Sounds ugly, but that's not material for now and cannot be applied to
older kernels, which need this fix as well.

BTW, there are more creative PIT users in drivers/input which use the
global lock already, but the PIT usage there is definitely broken on
anything >= 2.6.21.

> BTW, with all that usevent_supress busiess, does pcspkr gets loaded
> automatically nowadays?

I have no idea.

	tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/