Re: [PATCH] SCSI: Let users disable SCSI_WAIT_SCAN to be built

[James Bottomley]

On Wed, 2007-05-16 at 16:43 +0200, Stefan Richter wrote:
> I wrote:
> > --- linux-2.6.22-rc1.orig/drivers/scsi/Kconfig
> > +++ linux-2.6.22-rc1/drivers/scsi/Kconfig
> > @@ -241,11 +241,19 @@ config SCSI_SCAN_ASYNC
> >  	  You can override this choice by specifying "scsi_mod.scan=sync"
> >  	  or async on the kernel's command line.
> >  
> > -config SCSI_WAIT_SCAN
> > +config SCSI_WAIT_SCAN_NO_Y
> >  	tristate
> >  	default m
> > -	depends on SCSI
> > -	depends on MODULES
> 
> SCSI_WAIT_SCAN_NO_Y is unnecessary, as Randy Dunlap pointed out in "Re:
> How to force Kconfig tristate into range n..m?".
> http://lkml.org/lkml/2007/5/15/320
> 
> > +
> > +config SCSI_WAIT_SCAN
> > +	tristate "Pseudo driver which waits for SCSI scanning to finish"
> > +	depends on MODULES && SCSI && SCSI_WAIT_SCAN_NO_Y
> 
> 	depends on SCSI && m
> 
> > +	help
> > +	  When loaded, this module will do nothing else than wait for
> > +	  SCSI low-level drivers to finish asynchronous scanning.
> > +	  The module will be called scsi_wait_scan.
> 
> There should be explained that it is the command "modprobe
> scsi_wait_scan" which is doing the waiting, and that this is useful or
> required in initrds.
> 
> > +	  Most people can say n here.
> 
> This sentence should probably be omitted, as it may be wrong in the
> future and unsafe already now.
> 
> I will resend an updated patch.

Please don't bother ... I really want a more considered way of fixing
this.  If everyone decides the best way is exposing this to the user,
then this is the way to do it ... however, I still don't consider this
argument made out yet.

James

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index d28c14e..a6b95cd 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -242,10 +242,14 @@ config SCSI_SCAN_ASYNC
 	  or async on the kernel's command line.
 
 config SCSI_WAIT_SCAN
-	tristate
-	default m
+	tristate "Build Scan Wait Module"
+	depends on m
 	depends on SCSI
 	depends on MODULES
+	help
+	  The wait scan module builds a module which is used by
+	  initramdisk boots to wait for scans to complete after
+	  all SCSI modules have been loaded.  If unsure, say M here
 
 menu "SCSI Transports"
 	depends on SCSI


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/