Re: PROBLEM: 2.6.21 - "make modules" with GREP_OPTIONS="-C1" (andother)

[Kok, Auke]

Martin Christoph wrote:
> [1] Summary:
> If i have some GREP_OPTIONS set (like -C1 or other) i get several errors
> while trying to do "make modules".
>
> [2] Full description:
> With some GREP_OPTIONS set "make modules" drops several errors like that:
>
> root@spot /usr/src/linux # GREP_OPTIONS="-C1" make modules
>   CHK     include/linux/version.h
>   CHK     include/linux/utsrelease.h
>   Building modules, stage 2.
> [...]
> WARNING: "aes_enc_blk" [arch/i386/crypto/aes.ko] undefined!
> WARNING: "aes_dec_blk" [arch/i386/crypto/aes.ko] undefined!
> [...]
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> [3] Keywords:
> "make modules", "GREP_OPTIONS", "WARNING", "undefined"
>
> [X.] Suggestion to fix:
> Unset GREP_OPTIONS within make process.

While I admit that this will break the build, I think it's safe to say that 
there are hundreds of environment variables that will influence the kbuild 
system and makefiles. It's going to be an uphill battle if you want to fix each 
and every occurrence of a *possible* build breakage due to an environment 
variable being set wrongly.

I think it's perfectly fine for the kbuild system to expect a reasonably sane 
and clean build system. Those who want to set specific variables to influence 
their build should be able to do so as well, without getting settings removed.

In your case, I would suggest not setting this option by default in your shell ;)

Cheers,

Auke


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/