Re: [PATCH] ALPHA: MARVEL - check for allocated memory

From: Andrew Morton
Date: Wed May 16 2007 - 14:47:32 EST


On Wed, 16 May 2007 22:12:14 +0400
Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:

> This patch adds checking for allocated memory
> which is used to hold AGP info. Also some whitespace
> cleanup.

The inclusion of all the whitespace fixies makes it rather hard to
see what the patch actually does.

I'm not sure that I can be bothered with this, really. afaict the
checks you're adding are for boot-time allocations which we tend
to assume won't fail, and they're kmalloc(small-amount, GFP_KERNEL)
which is basically infallible, and it only affects, err, alpha.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/