Re: [PATCH] LogFS take three

[Pekka Enberg]

On 5/16/07, Jörn Engel <joern@xxxxxxxxxxxxxxx> wrote:
> > > +/* FIXME: all this mess should get replaced by using the page cache */
> > > +static void fixup_from_wbuf(struct super_block *sb, struct logfs_area
> > *area,
> > > +             void *read, u64 ofs, size_t readlen)
> > > +{
> >
> > Indeed. And I think you're getting some more trouble because of this...
>
> More trouble?

Forgot to add (see below). Seems logfs_segment_read would be simpler
too if you fixed this.

> [ Objects are the units that get compressed.  Segments can contain both
> compressed and uncompressed objects. ]
>
> It is a trade-off.  Each object has a 24 Byte header plus X Bytes of
> data.  Whether the data is compressed or not is indicated in the header.

Was my point really. Why do segments contain both compressed and
uncompressed objects?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/