Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

From: Michael-Luke Jones
Date: Wed May 16 2007 - 03:35:24 EST


On 16 May 2007, at 08:13, Christoph Hellwig wrote:

Not even trying to support LE is a clear merge blocker. Maybe Krzysztof
can't actually test it himself, which is fine - but not even pretending
to be endian clean is not what proper Linux drivers do.

w.r.t this comment, a working implementation LE implementation can be viewed here:

http://www.hohnstaedt.de/ixp_npe/0.3.1/ixp4xx_npe_driver-0.3.1.diff

Search in this file for "swap the payload of the SKB" (it's in mac_driver.c)

Michael-Luke Jones

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/