Re: [PATCH -mm] PM: Separate hibernation code from suspend code

From: Johannes Berg
Date: Mon May 07 2007 - 07:56:02 EST


On Mon, 2007-05-07 at 13:46 +0200, Johannes Berg wrote:
> On Sat, 2007-05-05 at 15:50 +0200, Rafael J. Wysocki wrote:
>
> > @@ -60,6 +60,9 @@ void hibernation_set_ops(struct hibernat
> > }
> > mutex_lock(&pm_mutex);
> > hibernation_ops = ops;
> > + if (ops)
> > + hibernation_mode = HIBERNATION_PLATFORM;
>
> else if (hibernation_mode == HIBERNATION_PLATFORM)
> hibernation_mode = HIBERNATION_SHUTDOWN;

Also, you could then simplify all the instances of
(hibernation_mode == HIBERNATION_PLATFORM && hibernation_ops)
to just
(hibernation_mode == HIBERNATION_PLATFORM)
in various if statements and other places.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part