Re: [RFC 1/3] SLUB: slab_ops instead of constructors / destructors

From: Pekka Enberg
Date: Sat May 05 2007 - 11:44:21 EST


On 5/5/07, clameter@xxxxxxx <clameter@xxxxxxx> wrote:
This patch gets rid constructors and destructors and replaces them
with a slab operations structure that is passed into SLUB.

Looks good to me.

On 5/5/07, clameter@xxxxxxx <clameter@xxxxxxx> wrote:
+struct slab_ops {
+ /* FIXME: ctor should only take the object as an argument. */
+ void (*ctor)(void *, struct kmem_cache *, unsigned long);
+ /* FIXME: Remove all destructors ? */
+ void (*dtor)(void *, struct kmem_cache *, unsigned long);
+};

For consistency with other operations structures, can we make this
struct kmem_cache_operations or kmem_cache_ops, please?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/