Re: [patch]clarification of coding style regarding conditional statements with two branches

From: Krzysztof Halasa
Date: Fri May 04 2007 - 12:17:07 EST


Jiri Slaby <jirislaby@xxxxxxxxx> writes:

> Why, what's wrong with
> if (condition) {
> do_this();
> do_that();
> } else
> otherwise();
>
> ? It's more readable/nicer in my eyes than

I think so. And it means less lines #.

>> +if (condition) {
>> + do_this();
>> + do_that();
>> +} else {
>> + otherwise();
>> +}

Exception:

if (x) {
if (y)
foo1();
else
foo2();
} else
bar();

The braces after if(x) are needed so nobody thinks it's:

if (x)
if (y)
foo1();
else
foo2();
else
bar();

--
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/