Re: [patch 04/33] m68k: Atari keyboard and mouse support.

[Christoph Hellwig]

On Thu, May 03, 2007 at 12:47:12PM +0200, Michael Schmitz wrote:
> On Tue, 1 May 2007, Christoph Hellwig wrote:
> 
> > What's the reason for splitting this up?  Things would be a quite a bit
> > simpler if all the code was directly in atakeyb.c.
> 
> Simple: I assumed that keeping the input driver code with the other input
> stuff was the Right Thing. I can move everything back to atakeyb.c if
> that's preferred.

I think keeping it all under arch/ makes more sense.  drivers/input/
makes a lot of sense where we have keyboard controllers that are used
on various architectures with slightly different glue, or different
controllers for the same busses.  IF you have really totally architecture
specific input devices that require intimate arch knowledge it probably
makes more sense to keep them there.

> > > +/*
> > > + * linux/atari/atakeyb.c
> 
> Shall I update that path, then? :-)

Just remove it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/