Re: [patch] CFS scheduler, -v8

From: Ingo Molnar
Date: Wed May 02 2007 - 07:18:48 EST



* Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:

> The problem is with comparing a s64 values with (s64)ULONG_MAX, which
> evaluates to -1. Then we check if exec_delta64 and fair_delta64 are
> greater than (s64)ULONG_MAX (-1), if so we assign (s64)ULONG_MAX to
> the respective values.

ah, indeed ...

> The fix is to compare these values against (s64)LONG_MAX and assign
> (s64)LONG_MAX to exec_delta64 and fair_delta64 if they are greater
> than (s64)LONG_MAX.
>
> Tested on PowerPC, the regression is gone, tasks are load balanced as
> they were in v7.

thanks, applied!

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/