Re: Remove open coded implementations of memclear_highpage flush

From: Andrew Morton
Date: Mon Apr 23 2007 - 22:25:16 EST


On Tue, 24 Apr 2007 07:49:45 +0530 "Satyam Sharma" <satyam.sharma@xxxxxxxxx> wrote:

> On 4/24/07, Christoph Lameter <clameter@xxxxxxx> wrote:
> > There are a series of open coded reimplementation of memclear_highpage_flush
> > all over the page cache code. Call memclear_highpage_flush in those locations.
> > Consolidates code and eases maintenance.
>
> If I remember right, a very similar patchset was recently submitted
> that Andrew merged in -mm(?).

yup.

> It also renamed memclear_highpage_flush
> to something like zero_user_page (though I wonder how good a name that
> is considering it takes an offset and not the whole page)

It's not a great name, but the fact that you must provide it with `offset'
and `length' arguments rather clears up any confusion ;)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/