Re: [PATCH 10/10] mm: per device dirty threshold

[Peter Zijlstra]

On Mon, 2007-04-23 at 08:48 -0700, Christoph Lameter wrote:
> On Sat, 21 Apr 2007, Peter Zijlstra wrote:
> 
> > > > This is enormously wrong for CONFIG_NR_CPUS=1024 on a 2-way.
> > 
> > Right, I knew about that but, uhm.
> > 
> > I wanted to make that num_online_cpus(), and install a hotplug notifier
> > to fold the percpu delta back into the total on cpu offline.
> 
> Use nr_cpu_ids instead. Contains the maximum possible cpus on this 
> hardware and allows to handle the hotplug case easily.

Ooh, thats handy... /me ditches the hotplug code again.
That is, unless its very common to have half empty boxens.. ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/