Re: [PATCH 7/8] Kconfig: silicon backplane dependency.

[Martin Schwidefsky]

On Sun, 2007-04-22 at 11:46 +0200, Michael Buesch wrote:
> > > No, this doesn't look right. There are other devices that come with
> > > SiliconBackplane but are not PCI or PCMCIA style devices.
> > 
> > Yes, Michael already told me about that. The current solution is to use
> > !S390, could we use HAS_IOMEM instead ?
> 
> I'd think either should be fine.

I will use HAS_IOMEM then. The oddity with the select statement still
exists though. I have to add the "depends on HAS_IOMEM" to SSB and B44.
If I just add it to SSB then the config option for B44 exists for s390
and you can enable it. The select statement will then enable SSB as well
(.config contains CONFIG_SSB=y for allyesconfig). This is in
contradiction to the depends statement since HAS_IOMEM=n on s390.

The current Kconfig code does not check all select statements if they
can be enabled before allowing the config option that does the select.
So the rule for using select statements is that the depends line of the
config option that selects another config option needs to be at least as
restrictive as the depends line of the selected option. Hence I'll add
the HAS_IOMEM depends to B44 as well. Okay ?

-- 
blue skies,              IBM Deutschland Entwicklung GmbH
   Martin                Vorsitzender des Aufsichtsrats: Johann Weihen
                         Geschäftsführung: Herbert Kircher
Martin Schwidefsky       Sitz der Gesellschaft: Böblingen
Linux on zSeries         Registergericht: Amtsgericht Stuttgart,
   Development           HRB 243294

"Reality continues to ruin my life." - Calvin.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/