Re: Sleep during spinlock in TPM driver

From: Jiri Kosina
Date: Mon Apr 23 2007 - 03:43:24 EST


On Sun, 22 Apr 2007, Parag Warudkar wrote:

> @@ -1097,8 +1097,13 @@
>
> /* Driver specific per-device data */
> chip = kzalloc(sizeof(*chip), GFP_KERNEL);
> - if (chip == NULL)
> + devname = kmalloc(DEVNAME_SIZE, GFP_KERNEL);
> + + if (chip == NULL || devname == NULL) {

Hi,

this line looks bogus to me.

--
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/