Re: [PATCH] utilities: add helper functions for safe 64-bit integeroperations as 32-bit halves

From: Alan Cox
Date: Sat Apr 21 2007 - 17:00:18 EST


> > +#define lower_32_bits(n) (sizeof(n) == 8 ? (u32)(n) : (n))
>
> n&0xffffffff would be simpler.
>
> Do we actually have any call for this?

The only case for all of this we care about is sector_t, which is one
type, with specific properties (eg always being positive). The rest is
over-engineering. Call it sector_upper32() do it the simple way and stop
trying to solve a problem we don't have
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/