Re: [patch 2/8] allow unprivileged umount

From: Andrew Morton
Date: Sat Apr 21 2007 - 03:57:00 EST


On Fri, 20 Apr 2007 12:25:34 +0200 Miklos Szeredi <miklos@xxxxxxxxxx> wrote:

> +static bool permit_umount(struct vfsmount *mnt, int flags)
> +{
>
> ...
>
> + return mnt->mnt_uid == current->uid;
> +}

Yes, this seems very wrong. I'd have thought that comparing user_struct*'s
would get us a heck of a lot closer to being able to support aliasing of
UIDs between different namespaces.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/