Re: [PATCH] dvb_en_50221: Convert to kthread API

From: Cedric Le Goater
Date: Fri Apr 20 2007 - 05:37:37 EST


Andrew Morton wrote:
> On Fri, 20 Apr 2007 07:37:14 +0100 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
>>> urgh, yes, this is just sad. We should convert this driver fully to
>>> the kthread API - it will end up much better.
>>>
>>> I'll queue this up as a -mm-only thing as a gentle reminder that
>>> we should do it properly.
>> Here's an attempted update to the full kthread API + wake_up_process:
>
> drivers/media/dvb/dvb-core/dvb_ca_en50221.c | 84 +++---------------
> 1 file changed, 16 insertions(+), 68 deletions(-)
>
> tasty!

Indeed !

I have sent a similar patch a few months ago :

http://lkml.org/lkml/2007/1/24/178

with a less aggressive diffstat though :)

Andrew (de Quincey) just drop mine, if you haven't already done. Christoph's is
more recent and looks better.

Thanks,

C.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/