Re: [PATCH 09/12] mm: count unstable pages per BDI

[Peter Zijlstra]

On Thu, 2007-04-19 at 21:20 +0200, Miklos Szeredi wrote:
> > Index: linux-2.6/fs/buffer.c
> > ===================================================================
> > --- linux-2.6.orig/fs/buffer.c	2007-04-19 19:59:26.000000000 +0200
> > +++ linux-2.6/fs/buffer.c	2007-04-19 20:35:39.000000000 +0200
> > @@ -733,7 +733,7 @@ int __set_page_dirty_buffers(struct page
> >  	if (page->mapping) {	/* Race with truncate? */
> >  		if (mapping_cap_account_dirty(mapping)) {
> >  			__inc_zone_page_state(page, NR_FILE_DIRTY);
> > -			__inc_bdi_stat(mapping->backing_dev_info, BDI_DIRTY);
> > +			__inc_bdi_stat(mapping->backing_dev_info, BDI_RECLAIM);
> 
> This name suggests it's _under_ reclaim, which is not true.  You might
> rather want to call it BDI_RECLAIMABLE, or something similar in
> meaning.

Yeah, my fingers got lazy on me :-) will instruct them to type more.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/