Re: [PATCH] Provide better abstraction for the serial drivers toxmit buf and tty

From: Alan Cox
Date: Wed Apr 18 2007 - 05:17:44 EST


> The basic reason for all this is to eventually allow the low-level
> serial drivers to function without a uart_info structure being
> allocated. This will allow the serial console, debuggers like kgdb,
> and the IPMI serial driver to use one interface to the uart code and

Its cheaper to allocate a uart_info that keep doing all the checks, at
least for port->info. I can see why you want to avoid port->info->tty as
a debugger can end up running before the tty layer and that would be hard
to work around.

For the other macros - the macros are more efficient than the equivalent
inline code generation at least for some gccs.

Do you really need any of this change but to check info->tty ?

Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/