Re: [PATCH v2] hpet: Enable hidden HPET on NVidia motherboards

[Andi Kleen]

Mikko Tiihonen <mikko.tiihonen@xxxxxx> writes:

> It looks probable that most NVidia chipsets have the HPET address at
> 0x44. It might be possible to enable the HPET even if BIOS did not

That seems like a dangerous assumption. If anything this needs to  be keyed
on specific PCI IDs.

And the way you coded a recursive PCI scan is just .... <looking for words, censoring
some that come to mind first> ... not nice.

> initialize it properly by writing the wanted address there. Some other
> pci config space bits might need to be fiddled around too, most likely
> candidates are 0x74 bit 2 and 0xA3 bit ?. One or both of them have been
> identified to change in some motherboards when HPET is enabled/disabled
> in BIOS.

Or just add a random generator and poke random bits? Should be roughly
equivalent.

Also there should be done anything here without confirmation from
Nvidia that HPET is actually supposed to work. Sometimes hardware
is disabled by BIOS because it is seriously broken (there was at least
one other chipset that could corrupt your flash if you force enabled
HPET in some steppings) 

-Andi
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/