Re: [PATCH] ACPI: more verbose thermal zone shutdown message

From: Danny Kukawka
Date: Mon Apr 16 2007 - 12:00:42 EST


On Sonntag, 15. April 2007, Pavel Machek wrote:
> Hi!
>
> > while debug some strange termal shutdowns I wrote this patch to get more
> > information in /var/log/messages about the reason for the shutdown. I
> > think this would be useful in general.
> >
> > Danny
> >
> > From: Danny Kukawka <dkukawka@xxxxxxx>
> > Subject: ACPI: more verbose thermal zone shutdown message
> >
> > add more information to acpi thermal zone shutdown message for easier
> > debugging
> >
> > Signed-off-by: Danny Kukawka <dkukawka@xxxxxxx>
>
> Yes, please.
[..]
> Why two printks with same info, and why is one of them WARNING and
> second EMERG?

I think this is what happen and why there are currently two messages:

* if the temperature is really critical you get (now) this:
----------------
kernel: Critical trip point (102 C) reached on Thermalzone [THM]
kernel: Critical temperature reached (150 C on [THM] with trip point set to:
102 C), shutting down.
----------------

* and if something send a critical temp event to the thermal zone you get:
----------------
kernel: Critical temperature reached (42 C on [THM] with trip point set to:
102 C), shutting down.
----------------

Maybe we can delete the first one, since you get now also from second
message the information if the temperature was really critical or if
there was an other reason for the shutdown, but in the past this was
IMO needed to differ.

Danny
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/