Re: [patch 1/3] epoll cleanups - epoll include diet ...

[Andrew Morton]

On Tue, 03 Apr 2007 18:35:06 -0700
Davide Libenzi <davidel@xxxxxxxxxxxxxxx> wrote:

> Remove some unneeded include files from epoll code.
> 

Our definitions of "unneeded" might differ.

> 
> Signed-off-by: Davide Libenzi <davidel@xxxxxxxxxxxxxxx>
> 
> 
> - Davide
> 
> 
> 
> Index: linux-2.6.21-rc5.mm4/fs/eventpoll.c
> ===================================================================
> --- linux-2.6.21-rc5.mm4.orig/fs/eventpoll.c	2007-04-03 17:59:54.000000000 -0700
> +++ linux-2.6.21-rc5.mm4/fs/eventpoll.c	2007-04-03 18:33:30.000000000 -0700
> @@ -1,6 +1,6 @@
>  /*
> - *  fs/eventpoll.c ( Efficent event polling implementation )
> - *  Copyright (C) 2001,...,2006	 Davide Libenzi
> + *  fs/eventpoll.c (Efficent event notification implementation)
> + *  Copyright (C) 2001,...,2007	 Davide Libenzi
>   *
>   *  This program is free software; you can redistribute it and/or modify
>   *  it under the terms of the GNU General Public License as published by
> @@ -17,30 +17,21 @@
>  #include <linux/sched.h>
>  #include <linux/fs.h>
>  #include <linux/file.h>
> -#include <linux/signal.h>
>  #include <linux/errno.h>
> -#include <linux/mm.h>
>  #include <linux/slab.h>
>  #include <linux/poll.h>
>  #include <linux/string.h>
>  #include <linux/list.h>
>  #include <linux/hash.h>
>  #include <linux/spinlock.h>
> -#include <linux/syscalls.h>
>  #include <linux/rwsem.h>
>  #include <linux/rbtree.h>
>  #include <linux/wait.h>
>  #include <linux/eventpoll.h>
> -#include <linux/mount.h>
> -#include <linux/bitops.h>
>  #include <linux/mutex.h>
>  #include <linux/anon_inodes.h>
>  #include <asm/uaccess.h>
> -#include <asm/system.h>
> -#include <asm/io.h>
> -#include <asm/mman.h>
>  #include <asm/atomic.h>
> -#include <asm/semaphore.h>

epoll uses signal stuff and might need signal.h.  It implements syscalls
and it certainly needs to have those syscall's prototypes in scope.  It
surely uses stuff from mm.h (doesn't everything??)

I am suspecting that this patch relies upon accidental nested inclusions
from within other headers.  But that is super-fragile: change a config
item, switch to a different architecture and whoops, it doesn't compile any
more.

Maybe I'm wrong, and you somehow worked out that none of these things which
these headers define, and none the things which these headers' includees
define is used in epoll.c or in the headers which are included after these
headers, or in those headers' includees.  If so, how the heck did you do
that?


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/