Re: [PATCH 02/12] mm: scalable bdi statistics counters.

From: Andrew Morton
Date: Thu Apr 05 2007 - 18:39:17 EST


On Thu, 05 Apr 2007 19:42:11 +0200
root@xxxxxxxxxxxxxxxxxxxxxxxxx wrote:

> Provide scalable per backing_dev_info statistics counters modeled on the ZVC
> code.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> ---
> block/ll_rw_blk.c | 1
> drivers/block/rd.c | 2
> drivers/char/mem.c | 2
> fs/char_dev.c | 1
> fs/fuse/inode.c | 1
> fs/nfs/client.c | 1
> include/linux/backing-dev.h | 98 +++++++++++++++++++++++++++++++++++++++++
> mm/backing-dev.c | 103 ++++++++++++++++++++++++++++++++++++++++++++

madness! Quite duplicative of vmstat.h, yet all this infrastructure
is still only usable in one specific application.

Can we please look at generalising the vmstat.h stuff?

Or, the API in percpu_counter.h appears suitable to this application.
(The comment at line 6 is a total lie).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/