Re: [PATCH 62/90] ARM: OMAP: Merge board specific files from N800 tree

[Tony Lindgren]

 * Randy Dunlap <randy.dunlap@xxxxxxxxxx> [070404 17:16]:
> On Wed,  4 Apr 2007 14:05:41 -0400 Tony Lindgren wrote:
> 
> > This patch merges board specific files from N800 tree.
> > Nokia has published the files at:
> > 
> 
> 2 comments:
> 
> a.  lots of printk() calls need log levels added as well as some
> indication of the source of the message, like a driver/module name
> or subsystem name[*]

I've update these to use dev_err() or dev_dbg() where possible,
and else use KERN_ERR or KERN_DEBUG.

> b.  externs should be in header files.

Moved them to board-nokia.h.

> * Maybe this isn't so critical for an embedded environment (?)

Updated patch attached.

Tony