Re: [PATCH] HPA support: Revised patch

[Jan-Benedict Glaw]

On Thu, 2007-04-05 14:13:52 +0100, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc5-mm4/drivers/ata/libata-core.c linux-2.6.21-rc5-mm4/drivers/ata/libata-core.c
> --- linux.vanilla-2.6.21-rc5-mm4/drivers/ata/libata-core.c	2007-04-03 16:56:32.000000000 +0100
> +++ linux-2.6.21-rc5-mm4/drivers/ata/libata-core.c	2007-04-03 17:08:28.000000000 +0100
> @@ -90,6 +90,10 @@
>  module_param_named(fua, libata_fua, int, 0444);
>  MODULE_PARM_DESC(fua, "FUA support (0=off, 1=on)");
>  
> +static int ata_ignore_hpa = 0;
> +module_param_named(ignore_hpa, ata_ignore_hpa, int, 0644);
> +MODULE_PARM_DESC(ignore_hpa, "Ignore HPA (0=off 1=on)");
> +
>  static int ata_probe_timeout = ATA_TMOUT_INTERNAL / HZ;
>  module_param(ata_probe_timeout, int, 0444);
>  MODULE_PARM_DESC(ata_probe_timeout, "Set ATA probing timeout (seconds)");

For ignore_hpa, it would be nice to not go through inverse logic and
fix the help text a bit (0=honor HPA, 1=ignore HPA).

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@xxxxxxxxxx              +49-172-7608481
Signature of:            http://www.chiark.greenend.org.uk/~sgtatham/bugs.html
the second  :

Attachment: signature.asc
Description: Digital signature