Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

[James Simmons]

> One non-technical question here...
> 
> > +config FB_VERMILION
> > +	tristate "Vermilion support"
> > +	depends on FB && PCI && X86
> > +	select FB_MODE_HELPERS
> > +	select FB_CFB_FILLRECT
> > +	select FB_CFB_COPYAREA
> > +	select FB_CFB_IMAGEBLIT
> > +	help
> > +	  This driver supports the Vermilion Range chipset
> 
> Is 'Vermillion' the project codename, or the name that end users will actually
> see when hardware ships?  Most of the Intel graphics chopsets have been
> named things like i810, i925, and so on - if the user-visible name is known,
> that should probably be reflected in the 'tristate' string and help
> text (FB_VERMILLION in the code is fine by be though).

I have to agree. I went looking for info on this card and I can't find 
anything. Please name it what the end user will expect.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/