Re: [patch 2/2] only allow nonlinear vmas for ram backedfilesystems

[Miklos Szeredi]

> > +		/*
> > +		 * page_mkclean doesn't work on nonlinear vmas, so if dirty
> > +		 * pages need to be accounted, emulate with linear vmas.
> > +		 */
> > +		if (mapping_cap_account_dirty(mapping)) {
> 
> Perhaps this should read:
> 
> 		if (vma_wants_writenotify(vma)) {
> 

I looked at that, but IIRC vma_wants_writenotify() doesn't work after
mmap(), because of the updated protection bits.

> That way we would even allow read only non-linear mappings of 'real'
> filesystem files.

Well, we could do that, but is it really worth the hassle?  The real
question is whether anyone would want to use non-linear
shared-read-only mappings or not.

Thanks,
Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/