Re: usb hid: reset NumLock

From: Dmitry Torokhov
Date: Wed Apr 04 2007 - 23:25:18 EST


On Tuesday 03 April 2007 04:52, Jiri Kosina wrote:
> On Mon, 2 Apr 2007, Pete Zaitcev wrote:
>
> > How about this?
>
> Looks quite fine to me.
>
> But in case that Dmitry's patch "Input: add generic suspend and resume for
> uinput devices" fixes your issue too, I wouldn't merge it as it won't be
> needed. Could you please let me know?

Unfortunately my patch is crap. We should not be sending events down
dev->event() until dev->open() has been called because many drivers
start hardware from there and not ready until then.

So it is HID driver responsibility to properly reset leds after all.

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/