Re: Performance Stats: Kernel patch

[Eric Dumazet]

On Wed, 04 Apr 2007 20:52:34 +0400
Maxim Uvarov <muvarov@xxxxxxxxxxxxx> wrote:


> Index: linux-2.6.18/include/asm/thread_info.h
> ===================================================================
> --- linux-2.6.18.orig/include/asm/thread_info.h
> +++ linux-2.6.18/include/asm/thread_info.h
> @@ -44,6 +44,9 @@ struct thread_info {
>                                                    of nested (IRQ) stacks
>                                                 */
>         __u8                    supervisor_stack[0];
> +#ifdef CONFIG_THREAD_PERF_STAT_SYSC
> +       unsigned long           sysc_cnt;           /* Syscall counter */
> +#endif /* CONFIG_THREAD_PERF_STAT_SYSC */
>  };
> 
>  #else /* !__ASSEMBLY__ */

You probably meant include/asm-i386/thread_info.h, not include/asm/thread_info.h

Then, you should not place sysc_cnt after supervisor_stack[0], since supervisor_stack[0] should be the last element of struct thread_info.

Better to put sysc_cnt right after preempt_count for example.

Also, is there any reason your patches are against 2.6.18, and not current kernel ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/