Re: [sched] redundant reschedule when set_user_nice() boosts a prio of a task from the "expired" array

[Dmitry Adamushko]

On 04/04/07, Ingo Molnar <mingo@xxxxxxx> wrote:
> * Dmitry Adamushko <dmitry.adamushko@xxxxxxxxx> wrote:
> > [...]
> >
> > The same is applicable to rt_mutex_setprio().
> >
> > Of course, not a big deal, but it's easily avoidable, e.g. (delta < 0
> > && array == rq->active).
>
> i think you are right and a micro-optimization could be done here. Would
> you like to do a patch for this?

Yes, I'll do it.

in fact, "delta < 0 && array == rq->active" is also sub-optimal.

"TASK_PREEMPTS_CURR(p, rq) && array == rq->active" seems to be ok.. or
maybe even TASK_PREEMPTS_CURR() should internally check for "p->array
== rq->active"...

will come with some solution.

Thanks.

>         Ingo

--
Best regards,
Dmitry Adamushko
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/