Re: [PATCH] vt: Expose system-wide UTF-8 default setting via sysfs

[Alexander E. Patrakov]

Antonino A. Daplas wrote:
> Create a variable, default_utf8, that defines the system-wide default UTF-8
> setting.  This variable can be altered via sysfs. If the variable is properly
> set, this should mimimize breakage of UTF-8 encoded consoles when doing a
> reset or echo -e '\033c' and of newly opened/allocated consoles.
>
> This is based from patches by Jan Engelhardt and Paul LeoNerd Evans.
>
> Signed-off-by: Antonino Daplas <adaplas@xxxxxxxxx>
> ---
> > I think you're missing the whole point of console reset.  Its purpose is 
> > to force the console into a known-good state.  The fewer pieces of state 
> > it leaves unset, the better.  To some degree it's less important what 
> > that state actually is.
>
> Okay, you convinced me. Hopefully this is acceptable to all parties.
>
> Andrew,
>
> If everybody agrees, can you drop the previous patch I sent to you, and use
> this instead?
>
> Tony
> +static int default_utf8;
> +module_param(default_utf8, int, S_IRUGO | S_IWUSR);

Module parameter without description and documentation? Yes, I understand 
that it is impossible to make vt a module. How about adding a line to 
Documentation/kernel-parameters.txt?

Other than that, the patch looks like a useful change.

--
Alexander E. Patrakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/