Re: [patch 13/13] signal/timer/event fds v9 - KAIO eventfd supportexample ...

[Davide Libenzi]

On Sun, 1 Apr 2007, Avi Kivity wrote:

> Davide Libenzi wrote:
> 
>  
> > > I think it's a bit too fine grained, and a new system call (io_bindfd()?)
> > > would be easier to use.  In addition, you would move the eventfd_fget()
> > > out of
> > > the submission path.
> > >     
> > 
> > IMO the cost of the eventfd_fget() (have you seen it?) is not worth adding a
> > new syscall.
> >   
> 
> There's an atomic op there (and another on the way out).  Probably on a busy
> cacheline.  Still it's probably lost in the noise.
> 
> Regardless of that, I think that specifying the fd per submission is wrong.
> It feels like a setup thing that needs to be done once.  We shouldn't skimp on
> syscalls, especially on something as important as unifying the async event
> model.

For userspace that wants to do that (that is, having iocbs signaled to an 
eventfd), do not really matter much. They have their own iocb setup function
and they'd simply set a flag more and set the resfd.
The global setting may be good for some users, with others that may 
complain in having to create another ctx just to set an fd.
Again, IMO is not worth a new API. What do other folks think?




- Davide


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/