Re: [PATCH 3/3] slab: avoid __initdata warning (may be a bogus one)

From: Andrew Morton
Date: Sun Apr 01 2007 - 03:31:45 EST


On Sun, 1 Apr 2007 00:15:06 -0700 (PDT) Christoph Lameter <clameter@xxxxxxx> wrote:

> On Sat, 31 Mar 2007, Andrew Morton wrote:
>
> > Yes, I think this is a flase positive - we'll never touch initkmem_list3[]
> > after free_initmem() because of the transitions of g_cpucache_up.
>
> Correct.
>
> > (In which case set_up_list3s() shoud be __init, too?)
>
> Correct. Its only called during slab bootstrap.
>
> > Christoph, I think you looked at this previously?
>
> If you change set_up_list3s to __init then we have the same issue with
> setup_cpu_cache right?

yup.

I wonder if there's a general way in which we can suppress such false
positives. Say, create a new section called, umm, __nowarn and
__nowarndata and then we can tag functions or data with those tags tag and teach
the checker tools to ignore them?


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/